Skip to content

Introduce sessionConnectionTimeout and updateRoutingTableTimeout #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 14, 2022

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Jul 11, 2022

sessionConnnectionTimeout is the maximum amount of time the session will wait when trying to establish a usable read/write connection to the remote host. This encompasses everything that needs to happen for this, including, if necessary, updating the routing table1, fetching a connection from the pool, and, if necessary performing a BOLT and Authentication handshake with the reader/writer.

updateRoutingTableTimeout is the maximum amount of time the driver will attempt to fetch a new routing table. This encompasses everything that needs to happen for this, including fetching connections from the pool, performing handshakes, and requesting and receiving a fresh routing table.

1Updating the routing table in turn might also require fetching a connection for the pool and performing the handshakes, plus potentially trying other routers.

bigmontz added 4 commits July 11, 2022 18:23
`sessionConnnectionTimeou` is the maximum amount of time the session will wait when trying to establish a usable read/write connection to the remote host. This encompasses *everything* that needs to happen for this, including, if necessary, updating the routing table<sup>1</sup>, fetching a connection from the pool, and, if necessary performing a BOLT and Authentication handshake with the reader/writer.
<sup>1</sup>Updating the routing table in turn might also require fetching a connection for the pool and performing the handshakes, plus potentially trying other routers.
@bigmontz bigmontz marked this pull request as ready for review July 12, 2022 13:42
bigmontz added 2 commits July 12, 2022 17:21
`updateRoutingTableTimeout` is the maximum amount of time the driver will attempt to fetch a new routing table. This encompasses *everything* that needs to happen for this, including fetching connections from the pool, performing handshakes, and requesting and receiving a fresh routing table.
@bigmontz bigmontz changed the title Introduce sessionConnectionTimeout Introduce sessionConnectionTimeout and updateRoutingTableTimeout Jul 12, 2022
Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ 🏃

@bigmontz bigmontz merged commit 6b90f8d into neo4j:5.0 Jul 14, 2022
@bigmontz bigmontz deleted the 5.0-sessionConnectionTimeoutMs branch July 14, 2022 10:46
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Jul 14, 2022
…eo4j#966)

`sessionConnnectionTimeout` is the maximum amount of time the session will wait when trying to establish a usable read/write connection to the remote host. This encompasses *everything* that needs to happen for this, including, if necessary, updating the routing table<sup>1</sup>, fetching a connection from the pool, and, if necessary performing a BOLT and Authentication handshake with the reader/writer.

`updateRoutingTableTimeout` is the maximum amount of time the driver will attempt to fetch a new routing table. This encompasses *everything* that needs to happen for this, including fetching connections from the pool, performing handshakes, and requesting and receiving a fresh routing table.

<sup>1</sup>Updating the routing table in turn might also require fetching a connection for the pool and performing the handshakes, plus potentially trying other routers.
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Jul 14, 2022
…eo4j#966)

`sessionConnnectionTimeout` is the maximum amount of time the session will wait when trying to establish a usable read/write connection to the remote host. This encompasses *everything* that needs to happen for this, including, if necessary, updating the routing table<sup>1</sup>, fetching a connection from the pool, and, if necessary performing a BOLT and Authentication handshake with the reader/writer.

`updateRoutingTableTimeout` is the maximum amount of time the driver will attempt to fetch a new routing table. This encompasses *everything* that needs to happen for this, including fetching connections from the pool, performing handshakes, and requesting and receiving a fresh routing table.

<sup>1</sup>Updating the routing table in turn might also require fetching a connection for the pool and performing the handshakes, plus potentially trying other routers.
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Jul 14, 2022
…eo4j#966)

`sessionConnnectionTimeout` is the maximum amount of time the session will wait when trying to establish a usable read/write connection to the remote host. This encompasses *everything* that needs to happen for this, including, if necessary, updating the routing table<sup>1</sup>, fetching a connection from the pool, and, if necessary performing a BOLT and Authentication handshake with the reader/writer.

`updateRoutingTableTimeout` is the maximum amount of time the driver will attempt to fetch a new routing table. This encompasses *everything* that needs to happen for this, including fetching connections from the pool, performing handshakes, and requesting and receiving a fresh routing table.

<sup>1</sup>Updating the routing table in turn might also require fetching a connection for the pool and performing the handshakes, plus potentially trying other routers.
bigmontz added a commit that referenced this pull request Jul 14, 2022
…966)

`sessionConnnectionTimeout` is the maximum amount of time the session will wait when trying to establish a usable read/write connection to the remote host. This encompasses *everything* that needs to happen for this, including, if necessary, updating the routing table<sup>1</sup>, fetching a connection from the pool, and, if necessary performing a BOLT and Authentication handshake with the reader/writer.

`updateRoutingTableTimeout` is the maximum amount of time the driver will attempt to fetch a new routing table. This encompasses *everything* that needs to happen for this, including fetching connections from the pool, performing handshakes, and requesting and receiving a fresh routing table.

<sup>1</sup>Updating the routing table in turn might also require fetching a connection for the pool and performing the handshakes, plus potentially trying other routers.
bigmontz added a commit that referenced this pull request Jul 15, 2022
bigmontz added a commit that referenced this pull request Jul 15, 2022
bigmontz added a commit that referenced this pull request Jul 15, 2022
bigmontz added a commit that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants