Fix Zoned DateTime support for dates before common era #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Years previous the common era were being treated as positive numbers causing the dates appear as positive numbers and breaking the auto-zone offset detection for zoned date times which were not created with the offset.
robsdedude
approved these changes
Sep 6, 2022
bigmontz
added a commit
to bigmontz/neo4j-javascript-driver
that referenced
this pull request
Sep 6, 2022
Years previous the common era were being treated as positive numbers causing the dates appear as positive numbers and breaking the auto-zone offset detection for zoned date times which were not created with the offset.
bigmontz
added a commit
that referenced
this pull request
Sep 6, 2022
Years previous the common era were being treated as positive numbers causing the dates appear as positive numbers and breaking the auto-zone offset detection for zoned date times which were not created with the offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Years previous the common era were being treated as positive numbers causing the dates appear
as positive numbers and breaking the auto-zone offset detection for zoned date times which were
not created with the offset.