feat: add timestamp variable#110
feat: add timestamp variable#110ali-ince merged 6 commits intoneo4j:mainfrom ali-ince:add-timestamp-variable
Conversation
| @@ -0,0 +1,7 @@ | |||
| org.slf4j.simpleLogger.defaultLogLevel=info | |||
There was a problem hiding this comment.
do we need logging by default?
could we turn it off, and only turn it on temporarily when troubleshooting?
There was a problem hiding this comment.
Given that this is just applicable for tests, I think having it enabled would help troubleshooting in case of failures in CI as well - that's why I kept them enabled by default.
There was a problem hiding this comment.
Got it. I usually push against logs enabled by default, as test assertions are theoretically enough.
However, we're dealing here with a complex test infrastructure here, so I'm not against it.
There was a problem hiding this comment.
The main reason for that is now we are using a random database and topic name per test case, and they are being logged through the logging infrastructure - which becomes quite important when you have a test failure.
2 participants
This PR adds message timestamp as a variable to cypher sink strategy.