refactor: change schema shape to support type changes for properties#166
Merged
ali-ince merged 10 commits intoneo4j:mainfrom Jul 30, 2024
Merged
refactor: change schema shape to support type changes for properties#166ali-ince merged 10 commits intoneo4j:mainfrom
ali-ince merged 10 commits intoneo4j:mainfrom
Conversation
fbiville
approved these changes
Jul 29, 2024
common/src/test/kotlin/org/neo4j/connectors/kafka/data/DynamicTypesTest.kt
Show resolved
Hide resolved
source-connector/src/test/kotlin/org/neo4j/connectors/kafka/source/Neo4jCdcSourceNodesIT.kt
Show resolved
Hide resolved
source-connector/src/test/kotlin/org/neo4j/connectors/kafka/source/Neo4jCdcSourceNodesIT.kt
Outdated
Show resolved
Hide resolved
...connector/src/test/kotlin/org/neo4j/connectors/kafka/source/Neo4jCdcSourceRelationshipsIT.kt
Show resolved
Hide resolved
fbiville
approved these changes
Jul 30, 2024
venikkin
reviewed
Jul 30, 2024
Contributor
venikkin
left a comment
venikkin
left a comment
There was a problem hiding this comment.
Have a comment about empty list serialization.
fbiville
reviewed
Jul 30, 2024
venikkin
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a breaking change where;
PropertyType),Map<String, PropertyType>for capturingpropertiesinbeforeandafterstates,