refactor: extract end-to-end test infrastructure and minor improvements#18
Merged
refactor: extract end-to-end test infrastructure and minor improvements#18
Conversation
fbiville
changed the title
ali-ince
approved these changes
Oct 16, 2023
Contributor
ali-ince
left a comment
ali-ince
left a comment
There was a problem hiding this comment.
looks good to me. just left a question which I think is not a blocker to merge this one.
ali-ince
reviewed
Oct 16, 2023
fbiville
force-pushed
the
source_improvements
branch
from
23bf9e0 to
8976dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the testing library (extension+assertions) to its own independent modules.
This also adds some basic tests on how the extension behaves.
This finally decouples the injected consumer's configuration from the Neo4j source's.