fix: use incoming object if schema is not defined#184
Merged
ali-ince merged 3 commits intoneo4j:mainfrom Sep 24, 2024
Merged
Conversation
ali-ince
changed the title
fbiville
reviewed
Sep 23, 2024
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jSinkRawJSONIT.kt
Outdated
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jSinkRawJSONIT.kt
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jSinkRawJSONIT.kt
Outdated
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jSinkRawJSONIT.kt
Outdated
Show resolved
Hide resolved
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jSinkRawJSONIT.kt
Outdated
Show resolved
Hide resolved
fbiville
approved these changes
Sep 23, 2024
sink-connector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jSinkRawJsonIT.kt
Outdated
Show resolved
Hide resolved
|
Hello, |
Contributor
Hello, please check the release here; https://github.com/neo4j/neo4j-kafka-connector/releases/tag/5.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
org.apache.kafka.connect.json.JsonConverteris not supported whenschemas.enableis set tofalsewhich should support incoming JSON strings.