fix: filter invalid keys from node change events#187
Merged
dhrudevalia merged 5 commits intoneo4j:mainfrom Oct 7, 2024
Merged
Conversation
fbiville
approved these changes
Oct 4, 2024
...nector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCdcSchemaFromStreamsMessageIT.kt
Show resolved
Hide resolved
Emrehzl94
reviewed
Oct 4, 2024
...nector/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jCdcSchemaFromStreamsMessageIT.kt
Outdated
Show resolved
Hide resolved
ali-ince
approved these changes
Oct 7, 2024
sink/src/main/kotlin/org/neo4j/connectors/kafka/sink/strategy/CdcSchemaHandler.kt
Outdated
Show resolved
Hide resolved
ali-ince
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1
If a Streams event contains a constraint that references a property that does not exist in the schema the resulting node operation is not completed.
Issue 2
If no valid keys are provided in a node event a cypher query which has no filtering is produced which can be dangerous.
Fix