Merged
Conversation
fbiville
reviewed
Oct 25, 2024
Contributor
fbiville
left a comment
There was a problem hiding this comment.
nicely done! just a few minor questions for me
common/src/main/kotlin/org/neo4j/connectors/kafka/configuration/Neo4jConfiguration.kt
Show resolved
Hide resolved
common/src/main/kotlin/org/neo4j/connectors/kafka/data/ChangeEventExtensions.kt
Show resolved
Hide resolved
common/src/main/kotlin/org/neo4j/connectors/kafka/data/ChangeEventExtensions.kt
Show resolved
Hide resolved
common/src/main/kotlin/org/neo4j/connectors/kafka/data/DynamicTypes.kt
Outdated
Show resolved
Hide resolved
common/src/main/resources/neo4j-source-configuration.properties
Outdated
Show resolved
Hide resolved
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
Collaborator
|
…kafka-connector into compact-payload-support merge changes from branch
fbiville
approved these changes
Oct 28, 2024
ali-ince
approved these changes
Oct 28, 2024
Contributor
ali-ince
left a comment
There was a problem hiding this comment.
Looks good. Just left a few minor comments.
common/src/main/resources/neo4j-source-configuration.properties
Outdated
Show resolved
Hide resolved
source-connector/src/test/kotlin/org/neo4j/connectors/kafka/source/Neo4jCdcSourceIT.kt
Show resolved
Hide resolved
Co-authored-by: Ali Ince <ali-ince@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration property to select the type of payload mode to be used by the source connector for serializing the data that will be published. The configuration property,
neo4j.payload-mode, has two options: EXTENDED and COMPACT. By default, the mode is set to EXTENDED.COMPACT: Produces a simpler, more minimal format with just the essential fields.
Example of COMPACT payload with JsonSchema;
EXTENDED: Includes additional information to handle schema changes and serialization issues of temporal types, ensuring consistency and preventing schema incompatibility issues.
Example of EXTENDED payload with JsonSchema;