Conversation
fbiville
force-pushed
the
sink-e2e
branch
2 times, most recently
from
c485157 to
c36d12d
Compare
this is a WIP
this is only mandatory if a session is injected, and that is validated by driver.verifyConnectivity before the test starts
also fixes licensing and improves naming of annotation value resolver
Fix sink registration and align source extension a little more.
ali-ince
reviewed
Oct 23, 2023
Contributor
ali-ince
left a comment
ali-ince
left a comment
There was a problem hiding this comment.
just a few minor comments, otherwise looks good.
sink/src/test/kotlin/org/neo4j/connectors/kafka/sink/Neo4jSinkIT.kt
Outdated
Show resolved
Hide resolved
testing/src/main/kotlin/org/neo4j/connectors/kafka/testing/sink/Neo4jSinkExtension.kt
Outdated
Show resolved
Hide resolved
testing/src/main/kotlin/org/neo4j/connectors/kafka/testing/sink/Neo4jSinkRegistration.kt
Outdated
Show resolved
Hide resolved
testing/src/main/kotlin/org/neo4j/connectors/kafka/testing/source/Neo4jSourceExtension.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a WIP