ci: execute git step in docker, validate version#35
Merged
venikkin merged 2 commits intoneo4j:mainfrom Nov 23, 2023
venikkin:fix-release-pipeline
Merged
ci: execute git step in docker, validate version#35venikkin merged 2 commits intoneo4j:mainfrom venikkin:fix-release-pipeline
venikkin merged 2 commits intoneo4j:mainfrom
venikkin:fix-release-pipeline
Conversation
ali-ince
approved these changes
Nov 23, 2023
Contributor
ali-ince
left a comment
ali-ince
left a comment
There was a problem hiding this comment.
looks good, just had one minor comment.
| git commit -m "build: release version %version%" | ||
| git push | ||
| """.trimIndent() | ||
|
|
Contributor
There was a problem hiding this comment.
just thought if we should be specific on what we include in git add such as git add **/pom.xml not to accidentally commit other changes?
Contributor
|
maybe we have add the following parameters to the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix few first identified issues:
Runbutton having emptyversiondespite ofallowEmpty = false- not entirely fixed, but remediated by validating versions as early as possible.