ci: add parent pom to versionalised commit, exclude release from teamcity main trigger#41
Merged
venikkin merged 7 commits intoneo4j:mainfrom Nov 28, 2023
venikkin:fix-release-commit
Merged
ci: add parent pom to versionalised commit, exclude release from teamcity main trigger#41venikkin merged 7 commits intoneo4j:mainfrom venikkin:fix-release-commit
venikkin merged 7 commits intoneo4j:mainfrom
venikkin:fix-release-commit
Conversation
…city main trigger
ali-ince
reviewed
Nov 27, 2023
Co-authored-by: Ali Ince <ali-ince@users.noreply.github.com>
Contributor
Author
ali-ince
reviewed
Nov 27, 2023
.teamcity/builds/Release.kt
Outdated
| goals = "versions:set" | ||
| runnerArgs = "$MAVEN_DEFAULT_ARGS -DnewVersion=%version% -DgenerateBackupPoms=false" | ||
| } | ||
| setVersion("Set release version", "releaseVersion") |
Contributor
There was a problem hiding this comment.
I'd only suggest that we set %releaseVersion% as the parameter to this function as that is the real value of the version to set or rename the argument name to versionParameter maybe?
ali-ince
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.