Skip to content

feat: introduce cdc client library#7

Merged
ali-ince merged 32 commits intoneo4j:mainfrom
ali-ince:cdc-client-library
Sep 25, 2023
Merged

feat: introduce cdc client library#7
ali-ince merged 32 commits intoneo4j:mainfrom
ali-ince:cdc-client-library

Conversation

@ali-ince
Copy link
Contributor

@ali-ince ali-ince commented Aug 3, 2023

This PR introduces a CDC client library which will be used by all CDC sourced connectors and provides a client layer to the CDC feature.

I have ported the discussion document into wiki.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Aug 18, 2023

Warnings
⚠️ Commit Message 'First draft of a CDC message model and parse.': subject may not be empty, subject may not end with full stop, type may not be empty
⚠️ Commit Message 'Implement client.': subject may not be empty, subject may not end with full stop, type may not be empty

Generated by 🚫 dangerJS against 2c71473

@ali-ince ali-ince marked this pull request as ready for review September 21, 2023 15:42
@meistermeier
Copy link
Contributor

I think this looks good in general.
One question: Do we want to have the CDC lib dependent on the parent Kafka project or really make it standalone?

@ali-ince
Copy link
Contributor Author

@meistermeier I'll extract this into a separate project detached from kafka.

@ali-ince
Copy link
Contributor Author

also the cdc module is now detached from the parent, making it easier for us to move it independently.

@ali-ince ali-ince merged commit 0e6ec08 into neo4j:main Sep 25, 2023
@ali-ince ali-ince deleted the cdc-client-library branch September 25, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants