Bookmarking - #104
Conversation
93ae985 to
10ac871
Compare
lutovich
left a comment
lutovich
left a comment
There was a problem hiding this comment.
@nigelsmall review completed, couple small comments.
| :return: Cypher result | ||
| :rtype: :class:`.StatementResult` | ||
| """ | ||
| self.last_bookmark = None |
There was a problem hiding this comment.
Do we need to do this initialization together with initialization in line 314?
There was a problem hiding this comment.
Ah, yes we do. This clears the bookmark before a run, it's not initialisation.
| def commit_transaction(self): | ||
| self.run("COMMIT") | ||
| result = self.run("COMMIT") | ||
| self.connection.sync() |
There was a problem hiding this comment.
Is there a way to test that we send commit and rollback messages eagerly?
There was a problem hiding this comment.
Tests added for that.
| self.der_encoded_server_certificate = config.get("der_encoded_server_certificate") | ||
|
|
||
| def on_success(metadata): | ||
| self.server_version = metadata.get("server") |
There was a problem hiding this comment.
server_version field is initialized here but where is it read?
There was a problem hiding this comment.
Just used in a test right now. It will conflict with #108 so I'll adjust it properly for that.
|
|
||
| def begin_transaction(self): | ||
| def begin_transaction(self, bookmark=None): | ||
| """ Create a new :class:`.Transaction` within this session. |
There was a problem hiding this comment.
Should docstring also say something about the bookmark parameter?
10ac871 to
aeeff47
Compare
90050c5 to
f705004
Compare
2 participants
No description provided.