Clean up neo4j.time public exports - #1191
Merged
Merged
Conversation
robsdedude
force-pushed
the
remove-time-internals
branch
2 times, most recently
from
May 20, 2025 13:12
58e5b0d to
2f91ff8
Compare
Make undocumented internal constants, helper functions, and other items in `neo4j.time` private: * `DATE_ISO_PATTERN` * `TIME_ISO_PATTERN` * `DURATION_ISO_PATTERN` * `NANO_SECONDS` * `AVERAGE_SECONDS_IN_MONTH` * `AVERAGE_SECONDS_IN_DAY` * `FORMAT_F_REPLACE` * `IS_LEAP_YEAR` * `DAYS_IN_YEAR` * `DAYS_IN_MONTH` * `round_half_to_even` * `symmetric_divmod` * `DateTimeType` * `DateType` * `TimeType` * all other indirectly exposed items from imports (e.g. `re` as `neo4j.time.re`)
robsdedude
force-pushed
the
remove-time-internals
branch
from
May 20, 2025 15:29
2f91ff8 to
134e799
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make undocumented internal constants, helper functions, and other items in
neo4j.timeprivate:DATE_ISO_PATTERNTIME_ISO_PATTERNDURATION_ISO_PATTERNNANO_SECONDSAVERAGE_SECONDS_IN_MONTHAVERAGE_SECONDS_IN_DAYFORMAT_F_REPLACEIS_LEAP_YEARDAYS_IN_YEARDAYS_IN_MONTHround_half_to_evensymmetric_divmodDateTimeTypeDateTypeTimeTypereasneo4j.time.re)Deprecate
ClockTimeand its accessorsneo4j.time.Date,neo4j.time.DateTime,neo4j.time.Timefrom_clock_timeandto_clock_timemethodsneo4j.time.ClockTimeitself