Fix driver stuck on RecursionError on COMMIT SUCCESS - #1192
Merged
robsdedude merged 3 commits intoMay 28, 2025
Merged
Conversation
The driver could get stuck when the result summary was so deeply nested that it caused an `RecursionError`. It would also get stuck on certain protocol violations in the same place (e.g., unknown PackStream tag). However, the latter is much more unlikely to occur. This patch will make the driver ditch the connection when it's not able to properly read a message for unexpected reasons.
robsdedude
force-pushed
the
fix/driver-stuck-on-recursion-error-in-commit-success
branch
from
May 20, 2025 12:35
58481ce to
1c5bc65
Compare
robsdedude
changed the title
MaxAake
approved these changes
May 23, 2025
robsdedude
enabled auto-merge (squash)
May 28, 2025 16:09
robsdedude
disabled auto-merge
May 28, 2025 16:09
robsdedude
enabled auto-merge (squash)
May 28, 2025 16:09
robsdedude
deleted the
fix/driver-stuck-on-recursion-error-in-commit-success
branch
May 28, 2025 17:01
This was referenced May 28, 2025
robsdedude
added a commit
that referenced
this pull request
Jun 5, 2025
…n-error-in-commit-success-5.0 Backport of: #1192
robsdedude
added a commit
that referenced
this pull request
Jun 5, 2025
…n-error-in-commit-success-4.4 Backport of: #1192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver could get stuck when the result summary was so deeply nested that it caused an
RecursionError. It would also get stuck on certain protocol violations in the same place (e.g., unknown PackStream tag). However, the latter is much more unlikely to occur.This patch will make the driver ditch the connection when it's not able to properly read a message for unexpected reasons and let the error bubble up.