Deprecate raw initial_bookmarks for bookmark_manager - #1196
Merged
robsdedude merged 3 commits intoMay 23, 2025
Conversation
robsdedude
force-pushed
the
deprecate-bmm-raw-initial-bookmarks
branch
from
May 22, 2025 10:11
c4dd0f1 to
a858acb
Compare
Deprecate passing raw sting bookmarks as `initial_bookmarks` to `GraphDatabase.bookmark_manager()`. Use a `neo4j.Bookmarks` object instead.
robsdedude
force-pushed
the
deprecate-bmm-raw-initial-bookmarks
branch
from
May 22, 2025 11:50
a858acb to
0f2f787
Compare
AndyHeap-NeoTech
approved these changes
May 23, 2025
AndyHeap-NeoTech
left a comment
AndyHeap-NeoTech
left a comment
Contributor
There was a problem hiding this comment.
Put it in a box and ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate passing raw sting bookmarks as
initial_bookmarkstoGraphDatabase.bookmark_manager().Use a
neo4j.Bookmarksobject instead.Amends #1175