Routing driver forgets addresses on some errors - #176
Merged
Conversation
Contributor
|
LGTM. CC @technige |
technige
suggested changes
Jul 28, 2017
technige
left a comment
technige
left a comment
Contributor
There was a problem hiding this comment.
Not keen on the error_handler changes to connection.py. It's quite unusual to dynamically attach methods in this way and the new try...except blocks catch all Exception types, which is generally considered too brute force.
I'm happy to pair on this.
Contributor
Author
|
@technige dynamic |
technige
approved these changes
Aug 22, 2017
This commit makes routing driver forget addresses and purge their connections on network and database errors. It also makes driver forget write server addresses when they fail as writers, connections remain in the pool because such machines can remain readers/routers.
To avoid comparing strings when handling routing errors.
Connection now takes a dedicated error handler object in constructor instead of having one dynamically attached after creation.
lutovich
force-pushed
the
1.5-forget-addresses-on-errors
branch
from
August 23, 2017 08:31
32274af to
9edcf42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes routing driver forget addresses and purge their connections on network and database errors. It also makes driver forget write server addresses when they fail as writers, connections remain in the pool because such machines can remain readers/routers.