Buffer resize - #206
Merged
Merged
Conversation
Still cannot locate where is the problem. Failed to reproduce it with a unit test. The guess of the cause of bug is related to reading a big chunk that cannot be fit in buffer after the first INIT message. It seems INIT might hold a reference to a memory view somewhere.
zhenlineo
force-pushed
the
1.5-buffer-capacity
branch
from
December 5, 2017 14:42
0dfa775 to
0ba73d1
Compare
zhenlineo
force-pushed
the
1.5-buffer-capacity
branch
from
December 5, 2017 15:13
0ba73d1 to
ae4d13e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the buffer resize issue due to not freeing reference in MessageFrame
Removed recursive call based on #204
Fixed the reference problem also in compiled C code.
Did not change recurse call in C code assuming C does not have a too big issue with recursion.