Skip to content

Apply 5.0 deprecation and renaming to neo4j.time module. #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

robsdedude
Copy link
Member

This makes the module more robust as it models sub-second precision with ints
instead of floats. This finishes off the work started in PR #551.

Breaking changes:

  • Duration
    • The constructor does not accept subseconds anymore.
      Use milliseconds, microseconds, or nanoseconds instead.
    • The property subseconds has been removed.
      Use nanoseconds instead.
    • The property hours_minutes_seconds has been removed.
      Use hours_minutes_seconds_nanoseconds instead.
    • For all math operations holds: they are element-wise on
      (months, days, nanoseconds).
      This affects (i.e., changes) the working of //, %, /, and *.
      • Years are equal to 12 months.
      • Weeks are equal to 7 days.
      • seconds, milliseconds, microseconds, and nanoseconds are
        implicitly converted to nanoseconds or seconds as fit.
    • Multiplication and division allow for floats but will always result in
      integer values (round to nearest even).
  • Time
    • The constructor does not accept floats for second anymore.
      Use nanosecond instead.
    • Ticks are now nanoseconds since midnight (int).
      • The property ticks_ns has been renamed to ticks.
        The old ticks is no longer supported.
      • The propertyfrom_ticks_ns has been renamed to from_ticks.
        The old from_ticks is no longer supported.
    • The property second returns an int instead of a float.
      Use nanosecond to get the sub-second information.
    • The property hour_minute_second has been removed.
      Use hour_minute_second_nanosecond instead.
  • DateTime
    • The property hour_minute_second has been removed.
      Use hour_minute_second_nanosecond instead.
    • The property second returns an int instead of a float.
      Use nanosecond to get the sub-second information.

@robsdedude robsdedude changed the base branch from 5.0-feature to 5.0 January 4, 2022 15:51
This makes the module more robust as it models sub-second precision with ints
instead of floats. This finishes off the work started in PR neo4j#551.

Breaking changes:
 - `Duration`
   - The constructor does not accept `subseconds` anymore.
     Use `milliseconds`, `microseconds`, or `nanoseconds` instead.
   - The property `subseconds` has been removed.
     Use `nanoseconds` instead.
   - The property `hours_minutes_seconds` has been removed.
     Use `hours_minutes_seconds_nanoseconds` instead.
   - For all math operations holds: they are element-wise on
     (`months`, `days`, `nanoseconds`).
     This affects (i.e., changes) the working of `//`, `%`, `/`, and `*`.
     - Years are equal to 12 months.
     - Weeks are equal to 7 days.
     - `seconds`, `milliseconds`, `microseconds`, and `nanoseconds` are
       implicitly converted to `nanoseconds` or `seconds` as fit.
   - Multiplication and division allow for floats but will always result in
     integer values (round to nearest even).
 - `Time`
   - The constructor does not accept `float`s for `second` anymore.
     Use `nanosecond` instead.
   - Ticks are now nanoseconds since midnight (`int`).
     - The property `ticks_ns` has been renamed to `ticks`.
       The old `ticks` is no longer supported.
     - The property`from_ticks_ns` has been renamed to `from_ticks`.
       The old `from_ticks` is no longer supported.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
 - `DateTime`
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
@robsdedude robsdedude force-pushed the clean-up-datetime-deprecation branch from 7301c9d to 53022c7 Compare January 4, 2022 17:00
@robsdedude robsdedude merged commit 97fd0e1 into neo4j:5.0 Jan 13, 2022
@robsdedude robsdedude deleted the clean-up-datetime-deprecation branch January 13, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant