Raise on using Results out of transaction scope #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
error-on-result-out-of-scope
branch
3 times, most recently
from
09f3390 to
4478986
Compare
robsdedude
force-pushed
the
error-on-result-out-of-scope
branch
3 times, most recently
from
167b0f7 to
444fb88
Compare
Results are tied to transactions (except auto-commit transactions). When the transaction ends, the result becomes useless. Raising instead of silently ignoring this fact will help developers to find potential bugs faster. After consuming a Result, there can never be records left. There is meaning in trying to obtain them. Hence, we raise a ResultError to make the user aware of potentially wrong code.
robsdedude
force-pushed
the
error-on-result-out-of-scope
branch
from
444fb88 to
709a91e
Compare
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Feb 9, 2022
…j#652) Results are tied to transactions (except auto-commit transactions). When the transaction ends, the result becomes useless. Raising instead of silently ignoring this fact will help developers to find potential bugs faster and avoid surprising and hard to understand behavior. After consuming a Result, there can never be records left. There is no meaning in trying to obtain them. Hence, we raise a `ResultConsumedError` to make the user aware of likely wrong code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results are tied to transactions (except auto-commit transactions).
When the transaction ends, the result becomes useless. Raising instead of
silently ignoring this fact will help developers to find potential bugs faster.
Depends on neo4j-drivers/testkit#387