Rename Session.x_transaction to Session.execute_x #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate `Session.read_transaction` and `Session.write_transaction` in favor of `Session.execute_read` and `Session.execute_write` respectively. Other drivers had to rename this function as there was a breaking change in the API. Namely, transaction functions getting passed a managed transaction object that has not commit/rollback/... methods, but can only run queries. The same change also applies to the Python driver but it's not breaking as the driver would've failed later (with a rather cryptic error coming from the server) when the user tried to manually commit/rollback/... a managed transaction inside a transaction function.
fbiville
approved these changes
Aug 30, 2022
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Aug 31, 2022
Amends neo4j#784 There were other mentions/usages of `Session.read/write_transaction` that needed replacing with `Session.execute_read/write`. While there was a test to make sure the example in the README works, there was no assertion the test actually tests what's in the README. Added a test to assert the former test resembles the README example.
robsdedude
added a commit
that referenced
this pull request
Aug 31, 2022
Amends #784 There were other mentions/usages of `Session.read/write_transaction` that needed replacing with `Session.execute_read/write`. While there was a test to make sure the example in the README works, there was no assertion the test actually tests what's in the README. Added a test to assert the former test resembles the README example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
Session.read_transactionandSession.write_transactionin favorof
Session.execute_readandSession.execute_writerespectively.Other drivers had to rename this function as there was a breaking change in the
API. Namely, transaction functions getting passed a managed transaction object
that has not commit/rollback/... methods, but can only run queries. The same
change also applies to the Python driver but it's not breaking as the driver
would've failed later (with a rather cryptic error coming from the server) when
the user tried to manually commit/rollback/... a managed transaction inside a
transaction function.