Logging overhaul #849
Merged
Logging overhaul #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
logging-overhaul
branch
from
cfe731d to
e3d85c3
Compare
* Add more logging to the pool when acquiring and releasing connections.
* Improved log format:
* All debug messages should not start with `[#hhhh] x:` where `hhhh` is the
hex representation of the local port number of the connection or 0000 if
there is none. `x` is one of `C` if it's the driver writing/opening/closing
onto the socket, `S` if it's the driver reading/receiving an error from
the socket and `_` if it's not communication between the server and the
driver.
* Reduced logging noise in routing table.
* API docs: explain how to manually log the async task id.
* Logging helpers `neo4j.debug`:
* Add config options to decide if thread id and/or task id should be logged.
* Their docs make clear that the logging format is not following semver.
* Changed logging format to accommodate the new config options.
robsdedude
force-pushed
the
logging-overhaul
branch
from
e3d85c3 to
0f74b9e
Compare
|
Here is what some logging looked like before This is what the same code logs now: |
bigmontz
approved these changes
Nov 2, 2022
robsdedude
force-pushed
the
logging-overhaul
branch
from
e13df11 to
69991fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#hhhh] x:wherehhhhis the hex representation of the local port number of the connection or 0000 if there is none.xis one ofCif it's the driver writing/opening/closing onto the socket,Sif it's the driver reading/receiving an error from the socket and_if it's not communication between the server and the driver.neo4j.debug: