Skip to content

Mature execute_query API #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Conversation

robsdedude
Copy link
Member

  • Renaming neo4j.RoutingControl.WRITERS to WRITE and READERS to READ.
  • Renaming driver.query_bookmark_manager() to execute_query_bookmark_manager().
  • Remove experimental tag from execute_query and its related APIs
    • driver.execute_query
    • driver.execute_query_bookmark_manager
    • AsyncBookmarkManager, BookmarkManager, the corresponding config option (session's bookmark_manager) and factory method (driver.bookmark_manager())
    • RoutingControl enum
    • EagerResult and result.to_eager_result()

 * Renaming `neo4j.RoutingControl.WRITERS` to `WRITE` and `READERS` to `READ`.
 * Renaming `driver.query_bookmark_manager()` to
   `execute_query_bookmark_manager()`.
 * Remove experimental tag from execute_query and its related APIs
   * `driver.execute_query`
   * `driver.execute_query_bookmark_manager`
   * `AsyncBookmarkManager`, `BookmarkManager`, the corresponding config option
     (session's `bookmark_manager`) and factory method
     (`driver.bookmark_manager()`)
   * `RoutingControl` enum
   * `EagerResult` and `result.to_eager_result()`
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔖 🕴🏼

@robsdedude robsdedude force-pushed the mature-execute-query branch from 85423e5 to 5e95802 Compare April 13, 2023 08:28
Warning checks in the TestKit backend were not merged properly.
@robsdedude robsdedude merged commit a6d9050 into neo4j:5.0 Apr 13, 2023
@robsdedude robsdedude deleted the mature-execute-query branch April 13, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants