Skip to content

feat(neon): Add Array extractor#1126

Merged
kjvalencik merged 1 commit intomainfrom
kv/array-extract
Feb 2, 2026
Merged

feat(neon): Add Array extractor#1126
kjvalencik merged 1 commit intomainfrom
kv/array-extract

Conversation

@kjvalencik
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

🐰 Bencher Report

Branchkv/array-extract
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
ThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
Upper Boundary
operations / second (ops/s)
(Limit %)
JsFunction::bind📈 view plot
🚷 view threshold
217.53 ns
(+6.77%)Baseline: 203.75 ns
183.37 ns
(84.30%)
407.49 ns
(53.38%)
📈 view plot
🚷 view threshold
4,597,159.16 ops/s
(-6.27%)Baseline: 4,904,648.61 ops/s
0.00 ops/s
(0.00%)
5,395,113.47 ops/s
(85.21%)
JsFunction::call📈 view plot
🚷 view threshold
223.31 ns
(+3.47%)Baseline: 215.83 ns
194.25 ns
(86.99%)
431.67 ns
(51.73%)
📈 view plot
🚷 view threshold
4,472,846.66 ops/s
(-3.19%)Baseline: 4,620,306.97 ops/s
0.00 ops/s
(0.00%)
5,082,337.67 ops/s
(88.01%)
JsFunction::call_with📈 view plot
🚷 view threshold
213.25 ns
(+4.70%)Baseline: 203.69 ns
183.32 ns
(85.96%)
407.37 ns
(52.35%)
📈 view plot
🚷 view threshold
4,663,582.78 ops/s
(-4.66%)Baseline: 4,891,573.46 ops/s
0.00 ops/s
(0.00%)
5,380,730.81 ops/s
(86.67%)
auto-exported-noop📈 view plot
🚷 view threshold
27.85 ns
(-5.63%)Baseline: 29.51 ns
26.56 ns
(95.37%)
59.02 ns
(47.18%)
📈 view plot
🚷 view threshold
35,904,857.75 ops/s
(+4.71%)Baseline: 34,289,010.60 ops/s
0.00 ops/s
(0.00%)
37,717,911.66 ops/s
(95.19%)
hello-world📈 view plot
🚷 view threshold
55.45 ns
(-4.48%)Baseline: 58.05 ns
52.24 ns
(94.22%)
116.09 ns
(47.76%)
📈 view plot
🚷 view threshold
17,907,364.04 ops/s
(+3.75%)Baseline: 17,260,464.68 ops/s
0.00 ops/s
(0.00%)
18,986,511.15 ops/s
(94.32%)
manually-exported-noop📈 view plot
🚷 view threshold
27.85 ns
(-1.87%)Baseline: 28.38 ns
25.54 ns
(91.72%)
56.77 ns
(49.06%)
📈 view plot
🚷 view threshold
35,900,765.92 ops/s
(+1.91%)Baseline: 35,228,701.67 ops/s
0.00 ops/s
(0.00%)
38,751,571.83 ops/s
(92.64%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 60.93750% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.80%. Comparing base (303eb3c) to head (2d071bc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/neon/src/types_impl/extract/array.rs 60.93% 24 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   83.16%   82.80%   -0.37%     
==========================================
  Files          80       81       +1     
  Lines        5739     5756      +17     
  Branches     5739     5756      +17     
==========================================
- Hits         4773     4766       -7     
- Misses        848      871      +23     
- Partials      118      119       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kjvalencik kjvalencik force-pushed the kv/array-extract branch 2 times, most recently from b02196c to 62faa2f Compare January 2, 2026 20:37
Copy link
Copy Markdown
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this!

Comment thread crates/neon/src/types_impl/extract/array.rs Outdated
Comment thread crates/neon/src/types_impl/extract/array.rs Outdated
@kjvalencik kjvalencik marked this pull request as ready for review January 23, 2026 16:43
Copy link
Copy Markdown
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kjvalencik kjvalencik merged commit 252a5b6 into main Feb 2, 2026
10 checks passed
@kjvalencik kjvalencik deleted the kv/array-extract branch February 2, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants