fix(astro): using vim.fs.jointhpath concat path #3741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: hardcord path symbol in get_typescript_server_path Solution: using vim.fs.joinpath to concat path
justinmk
reviewed
Apr 17, 2025
| @@ -1,6 +1,6 @@ | |||
| local function get_typescript_server_path(root_dir) | |||
| local project_root = vim.fs.dirname(vim.fs.find('node_modules', { path = root_dir, upward = true })[1]) | |||
| return project_root and (project_root .. '/node_modules/typescript/lib') or '' | |||
| return project_root and vim.fs.joinpath(project_root, 'node_modules', 'typescript', 'lib') or '' | |||
There was a problem hiding this comment.
string literals don't need to be joined. just use "/".
vim.fs.joinpath(project_root, 'node_modules/typescript/lib')
There was a problem hiding this comment.
right it gsub path separator according to the system.
There was a problem hiding this comment.
"/" works everywhere. platform-specific slash isn't needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: hardcord path symbol in get_typescript_server_path
Solution: using vim.fs.joinpath to concat path