feat(jsonnet_ls): jsonnet_ls lsp #3825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithammer
reviewed
May 7, 2025
ilpianista
force-pushed
the
feature/lsp-jsonnet_ls
branch
3 times, most recently
from
e7ee921 to
2d3d28c
Compare
lithammer
reviewed
May 7, 2025
ilpianista
force-pushed
the
feature/lsp-jsonnet_ls
branch
from
2d3d28c to
1ca50fc
Compare
lithammer
approved these changes
May 7, 2025
There was a problem hiding this comment.
I guess this is one of those cases where cmd_env being function with the buffer being attached or root_dir as argument would be useful.
It also seems like the solution in lua/lspconfig/configs/jsonnet_ls.lua is incorrect for Windows since it's splitting on :. It should split on ;.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should remove
jsonnet_lsfrom the list in #3705.