feat(tailwindcss): Add Tailwind detection for Elixir Phoenix projects #3831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernheisel
force-pushed
the
db-add-tailwind-mix-lock
branch
2 times, most recently
from
0eb260b to
3ecb4a5
Compare
This PR enhances root directory detection for the latest versions of TailwindCSS v4, which no longer require tailwind.config.* or postcss.config.*. For Phoenix projects, they are typically generated or add Tailwind installed via https://github.com/phoenixframework/tailwind which will now be detected by scanning the mix.lock file for the included package. Phoenix projects that install tailwindcss via package.json should still work.
dbernheisel
force-pushed
the
db-add-tailwind-mix-lock
branch
from
3ecb4a5 to
d46fd12
Compare
justinmk
reviewed
May 10, 2025
| --- | ||
| --- NOTE: this does a "breadth-first" search, so is broken for multi-project workspaces: | ||
| --- https://github.com/neovim/nvim-lspconfig/issues/3818#issuecomment-2848836794 | ||
| function M.insert_mix_exs(config_files, field, fname) |
There was a problem hiding this comment.
We're trying to eliminate util.lua, not grow it.
As a compromise, I will merge this and followup with a PR that generalizes insert_package_json, it has no reason to hardcode 'package.json', 'package.json5' ...
|
Could you please confirm that #3833 works for you? |
|
@justinmk yessir! works great. Thanks for making it more extensible! |
|
@justinmk I just realized that lspconfig has two configs for lsps now:
I suppose the older style is best-effort, but is there any reason not to update the older style? |
old configs are frozen and will be deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances root directory detection for the latest versions of TailwindCSS (v4), which no longer require tailwind.config.* or postcss.config.*, for Elixir/Phoenix projects. Phoenix projects generate with Tailwind installed via https://github.com/phoenixframework/tailwind.