feat(ast_grep): support multiple workspaces #3866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
May 23, 2025
lua/lspconfig/configs/ast_grep.lua
Outdated
| @@ -3,6 +3,10 @@ local util = require 'lspconfig.util' | |||
| return { | |||
| default_config = { | |||
| cmd = { 'ast-grep', 'lsp' }, | |||
| reuse_client = function(client, config) | |||
There was a problem hiding this comment.
are you sure the old configs support reuse_client ? they are frozen anyway, as noted by the failing CI check.
There was a problem hiding this comment.
Yeah, but… it should be provided in second arg to lsp.start.client: https://github.com/neovim/neovim/blob/v0.10.0/runtime/doc/lsp.txt#L858
I've no idea is this handled by lspconfig or this callback should be in some other place in the config or there is no place for it at all.
Should I just remove it?
powerman
force-pushed
the
feat-ast_grep-cwd
branch
from
f8a7a79 to
87ea61d
Compare
|
Removed old config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3850