(enh) moonscript supports eval now #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
commented
Jan 9, 2022
src/api/moonscript.c
Outdated
| @@ -91,6 +108,9 @@ static bool initMoonscript(tic_mem* tic, const char* code) | |||
| return false; | |||
| } | |||
|
|
|||
| lua_setglobal(lua, "_ms_loadstring"); | |||
| lua_getglobal(lua, "_ms_loadstring"); | |||
There was a problem hiding this comment.
Dunno if there is a better way to do this... I was looking for lua_tee or something, but couldn't find.
There was a problem hiding this comment.
Honestly, I don't understand what's going on here :)
Also, could you pls move the "_ms_loadstring" to static const char _ms_loadstring[] = "_ms_loadstring" variable?
There was a problem hiding this comment.
Well, Lua is stack based, so setting a global removes it from the stack so you have to put it back on the stack... I was looking for a "duplication item on top of stack" API, but didn't see it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.