Skip to content

order langauges by alphabetical order #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

joshgoebel
Copy link
Collaborator

If we aren't playing favorites anymore then this order really should be alphabetical, not historic.

@nesbox nesbox merged commit 612fc62 into nesbox:master Jan 10, 2022
@remi6397
Copy link
Contributor

remi6397 commented Jan 10, 2022

This made fennel the default language (not that I complain). 😁✌️

@joshgoebel
Copy link
Collaborator Author

Default in what sense? New does not have a default anymore.

@remi6397
Copy link
Contributor

remi6397 commented Jan 10, 2022

Not the language, I mean the demo that's loaded by default, it used to be the Lua hello. Maybe we should randomize it? 😄

Also fallback symbols, etc.

see console.c:1075

@joshgoebel
Copy link
Collaborator Author

Oops, that was unintentional. @nesbox Should we go back and hard-wire Lua as the starter language when the app first opens?

@nesbox
Copy link
Owner

nesbox commented Jan 11, 2022

Should we go back and hard-wire Lua as the starter language when the app first opens?

of course, Lua has to be the first, also I need to be more careful when reviewing PRs

nesbox added a commit that referenced this pull request Jan 11, 2022
…ages"

This reverts commit 612fc62, reversing
changes made to c3efe28.
@nesbox
Copy link
Owner

nesbox commented Jan 11, 2022

reverted here 7364cbb

@joshgoebel
Copy link
Collaborator Author

Could we have just have fixed the default issue without reverting the ordering?

@nesbox
Copy link
Owner

nesbox commented Jan 11, 2022

Please make new PR with the fixed ordering and Lua by default, I don't see other variants.
Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants