add apt install resolvconf for fix resolvconf missing make wt0 interface

[yimiaoxiehou]

as title to fix #4811

Summary by CodeRabbit

• Chores
  • Updated installation process to include an additional system dependency, ensuring all required components are installed during setup.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

The installation script for apt package manager systems was updated to include resolvconf as an additional package dependency alongside NetBird, ensuring DNS resolution functionality is available on Debian and Ubuntu systems.

Changes

Cohort / File(s)	Summary
Install script dependency update release_files/install.sh	Updated apt installation command to include resolvconf package alongside netbird for DNS resolution support

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Single-line change to package manager installation command
• Straightforward dependency addition with clear rationale from linked issue

Poem

🐰 A missing resolve, a loop most cruel,
The daemon danced by DNS rule,
Now resolvconf joins the fight,
Keeping wt0 shining bright! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	PR description is minimal but references the linked issue #4811. However, it is missing required template sections including detailed change description, checklist items, and documentation selection.	Complete the PR description template by adding: (1) detailed explanation in 'Describe your changes' section, (2) check appropriate item in the checklist, (3) select a documentation option, and (4) fill in the 'Docs PR URL' field if applicable.
Linked Issues check	⚠️ Warning	The PR adds resolvconf installation which directly addresses issue #4811's root cause, but does not implement the expected behavior of graceful DNS failure handling and wt0 persistence.	The installation of resolvconf is preventive but incomplete. Also implement graceful handling of missing resolvconf by logging DNS failures without treating them as fatal, and prevent wt0 destruction on DNS setup failures.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title describes a concrete change (adding apt install resolvconf) relevant to fixing the linked issue, though the phrasing is slightly awkward.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to adding resolvconf to the apt installation command in install.sh, which is directly related to the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05cbead and 12a10af.

📒 Files selected for processing (1)

• release_files/install.sh (1 hunks)

🔇 Additional comments (1)

release_files/install.sh (1)

226-226: The review comment's claims about the root cause are unsupported by the codebase.

After examining the daemon code, DNS errors are already handled gracefully:

• engine.go (lines 1051-1052): if err := e.dnsServer.UpdateDNSServer(...) { log.Errorf(...) } — logs and continues
• dns/server.go (line 589-590): if err := s.hostManager.applyDNSConfig(...) { log.Errorf(...) } — logs and continues

The daemon does NOT treat DNS setup failures as fatal. Graceful error handling is already implemented. Installing resolvconf prevents the error from occurring in the first place, but no root cause fix in the daemon is needed.

However, the observation about incomplete package manager coverage is valid: resolvconf is only added to apt (line 226), not to yum/dnf/rpm-ostree/brew, creating inconsistency across distributions.

Likely an incorrect or invalid review comment.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[mlsmaycon]

Thanks for your PR @yimiaoxiehou . We need to investigate the issue before moving forward with it. Also, we should make this installation optional since the default behavior on Debian and Ubuntu is usually fine.