Skip to content

Conversation

@DaCaub
Copy link

@DaCaub DaCaub commented Dec 5, 2025

This update aligns the template with the actual behavior of the Signal service and the official NetBird documentation.

Describe your changes

The advanced-setup docker-compose.yml template incorrectly mapped:

# Signal
  signal:
    ....
    ports:
  - $NETBIRD_SIGNAL_PORT:80

However, the netbird-signal container listens on port 10000 internally.

This mismatch caused external Signal connections to fail unless users manually adjusted their NAT/firewall rules or remapped the port.
The update changes the port mapping to:

# Signal
  signal:
    ....
    ports:
  - $NETBIRD_SIGNAL_PORT:10000

This ensures correct behavior out of the box and makes the template consistent with the actual service configuration and official documentation.

Issue ticket number and link

N/A — Bug discovered during advanced setup deployment.
(If an issue is later opened, it can be added here.)

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (the fix corrects an incorrect port mapping in the docker template; no user-facing feature or behavior is changed, only the template is corrected to match the actual service port.)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

N/A

Summary by CodeRabbit

  • Chores
    • Updated Signal service port configuration in deployment setup.

✏️ Tip: You can customize this high-level summary in your review settings.

This update aligns the template with the actual behavior of the Signal service and the official NetBird documentation.
Copilot AI review requested due to automatic review settings December 5, 2025 14:12
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2025

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Walkthrough

The Signal service port mapping in the Docker Compose template is updated from host port 80 to port 10000. The container port is changed from 80 to 10000, and the environment variable $NETBIRD_SIGNAL_PORT now correctly maps to the updated container port.

Changes

Cohort / File(s) Change Summary
Signal Service Port Configuration
infrastructure_files/docker-compose.yml.tmpl
Updated Signal service port mapping from $NETBIRD_SIGNAL_PORT:80 to $NETBIRD_SIGNAL_PORT:10000

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Poem

🐰 A port tweak, so small yet keen,
From eighty to ten-thousand, pristine!
The Signal now hops to the right destination,
Docker compose dances in configuration! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: updating the Signal service port mapping from 80 to 10000 in the docker-compose template.
Description check ✅ Passed The description includes all required template sections: detailed explanation of changes with code examples, issue reference, checklist completion, CLA acknowledgment, and documentation selection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f538e6e and 6b22c9b.

📒 Files selected for processing (1)
  • infrastructure_files/docker-compose.yml.tmpl (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Agent
🔇 Additional comments (1)
infrastructure_files/docker-compose.yml.tmpl (1)

49-49: Verify Signal service port configuration before accepting this change.

The review claims the Signal service listens on port 10000 internally, but this should be verified against the actual service configuration. Confirm:

  • Signal service is configured to listen on port 10000, not port 80
  • No other configuration files or documentation reference the old port 80 mapping for Signal
  • Environment variable examples and defaults are consistent with this change

Unable to verify these claims against the codebase automatically. Manual verification is required to confirm this is a critical bug fix.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the advanced-setup docker-compose template where the Signal service port mapping was incorrectly configured. The Signal container, when running with TLS certificates (as configured in this template), listens on port 443 (main HTTP/gRPC multiplexed server) and port 10000 (legacy gRPC compatibility port), but not on port 80. The previous mapping $NETBIRD_SIGNAL_PORT:80 would fail because no service listens on port 80 inside the container when TLS is enabled. The fix changes the mapping to $NETBIRD_SIGNAL_PORT:10000, which correctly maps to the legacy gRPC port that the Signal service actually listens on.

Key changes:

  • Updated Signal service port mapping from port 80 to port 10000 in the docker-compose template
  • Aligns with the default value of NETBIRD_SIGNAL_PORT=10000 configured in base.setup.env
  • Ensures the Signal service is accessible as expected by the management server configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants