Update netbox_api.py - Fix Error creating manufacturers (Only some of the manufacturers were imported.) #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Troubleshooting “Error creating manufacturers” Only a part of the data was imported. Cisco, Opengear, Fortinet e.g. not. Removes: netbox-community#172 Perhaps also: netbox-community#169 netbox-community#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Troubleshooting “Error creating manufacturers” Only a part of the data was imported. Cisco, Opengear, Fortinet e.g. not.
Thanks to chatgpt
Removes:
#172
Perhaps also:
#169
#123
📝 What has changed?
✅ Automatically generate slug using vendor.setdefault('slug', ...)
✅ Check for existing vendors by name or slug
✅ Improved log entries (now showing name and slug)
✅ Output includes how many vendors were newly created
✅ API error messages are displayed directly for better visibility
✅ Result:
With this function, no duplicate vendors will be created (whether matching by name or slug),
and if an error occurs, the exact API error message will be immediately visible.
Befor
After Change:
