Skip to content

Front & Rear Elevation Images #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danner26 opened this issue Jan 6, 2023 · 7 comments
Closed

Front & Rear Elevation Images #1036

danner26 opened this issue Jan 6, 2023 · 7 comments

Comments

@danner26
Copy link
Member

danner26 commented Jan 6, 2023

We are currently in the process of having a discussion on whether we will be able to include front and rear rack elevation images as part of this structured data. The maintainers are talking internally on how to best handle this, if possible, and consulting with legal counsel on the possible drawbacks of doing so.

We are evaluating these three following options: (feel free to comment if you have anymore)

  1. Hosting the images within this repository, or more likely within another NetBox Community repository
  2. Adding URL links to the structured data which reference the appropriate images URL
  3. A combination of 1 and 2, where number option 2's URLs will point to option 1's repository

If you have any insight or thoughts about the topic, please feel free to drop a comment.

@danner26 danner26 added the status: under review A Pull Request (PR) or Issue that is current in review by a maintainer label Jan 6, 2023
@abhi1693
Copy link
Member

abhi1693 commented Jan 9, 2023

Cisco provides Visio stencils of all of their devices at https://www.cisco.com/c/en/us/products/visio-stencil-listing.html. As long as these are not altered, these can be freely used. Maybe other vendors also provides such links

@mpsOxygen
Copy link

This would be amazing as having to add them by hand can be a real PITA. I think adding the image data in another repo would be the best way to go as URLs are prone to breaking in time, especially for smaller manufacturers.

@Wlanfr3ak
Copy link
Contributor

I would also make my own photos for it, so that there are fewer problems with image rights. This is in any case something that I really missing so far in the repository and I have always inserted in our system as an extra. I could also imagine that some manufacturers would release graphics for it.

@jsenecal
Copy link
Contributor

We must also consider that Github allows for copyrighted material under Fair Use, It may not be a problem after all to host them here, on github.

@m2martin
Copy link
Contributor

Another option to discuss:
To overcome the need for downloading files from public sources, it may be applicable to create a kind of self-contained import file where the images are included in the YAML for example as base64 string which will be saved to the filesystem in the import step.

@kkthxbye-code kkthxbye-code removed their assignment Feb 10, 2023
@github-actions github-actions bot added the stale label Mar 13, 2023
@jbemmel
Copy link
Contributor

jbemmel commented Mar 17, 2023

I uploaded front/rear images for Nokia devices to the repo: #1210

Keeping them together with the device definitions makes most sense to me - I checked with our marketing department and got the ok, so uploading them here implies permission to use (within the context of Netbox)

@danner26
Copy link
Member Author

All, I have added documentation regarding the front and rear images. All device images must be placed within the manufacturer folder within the elevation-images folder in this repo. The manufacturers folder needs to be named exactly the same as the device-types and the module-types folders.

After the manufacturer folder is created, you can then start adding your images. It is required that the file name follows this format:

  1. The first part of the name must be a part of the slug which identifies the device, i.e. 7220-IXR-H3
  2. The second part of the file name indicates whether it is a front or rear image, with a dot as the delimiter. This should look like .front or .rear
  3. The final part of the file name is the file type. This can be any of the following types ('bmp', 'gif', 'pjp', 'jpg', 'pjpeg', 'jpeg', 'jfif', 'png', 'tif', 'tiff', 'webp'). Of course you need a dot in front of the file type as well, i.e. .png or .jpg, etc.

PR #1225 resolves this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants