Skip to content

Add front/rear images for Nokia devices #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add front/rear images for Nokia devices #1210

wants to merge 8 commits into from

Conversation

jbemmel
Copy link
Contributor

@jbemmel jbemmel commented Mar 17, 2023

All images are 226x19 PNG, and can be imported using the enhanced tool (separate PR)

@danner26
Copy link
Member

Hey @jbemmel, rather than keeping the images in the same folder as the definitions lets create a new folder for all images.

I already have an implementation ready. I will get that merged to master soon so you can utilize it

@danner26
Copy link
Member

danner26 commented Mar 24, 2023

@jbemmel I have added documentation regarding the front and rear images. All device images must be placed within the manufacturer folder within the elevation-images folder in this repo. The manufacturers folder needs to be named exactly the same as the device-types and the module-types folders.

After the manufacturer folder is created, you can then start adding your images. It is required that the file name follows this format:

  1. The first part of the name must be a part of the slug which identifies the device, i.e. 7220-IXR-H3
  2. The second part of the file name indicates whether it is a front or rear image, with a dot as the delimiter. This should look like .front or .rear
  3. The final part of the file name is the file type. This can be any of the following types ('bmp', 'gif', 'pjp', 'jpg', 'pjpeg', 'jpeg', 'jfif', 'png', 'tif', 'tiff', 'webp'). Of course you need a dot in front of the file type as well, i.e. .png or .jpg, etc.

Please let me know if you need anything else.

@danner26
Copy link
Member

Hey @jbemmel is this still needed/still being worked on?

@jbemmel
Copy link
Contributor Author

jbemmel commented Mar 30, 2023

Replaced by #1233

@jbemmel jbemmel closed this Mar 30, 2023
@jbemmel jbemmel deleted the nokia_add_images branch March 30, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants