10458 add "Location" to CircuitTermination #10458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model and form
if location is set, show location if site only is set, show site (as before) if provider_network only is set, show provider_network (as before)
if location is set, show location if site only is set, show site (as before) if provider_network only is set, show provider_network (as before)
gjvc
changed the title
|
Thanks for your interest in working on this, however please note that #9604 has not been assigned a release milestone (required as this would be a breaking change to the API) and thus is not yet ready for work. |
|
Sure thing; I will keep an eye on the original issue and this PR and will resubmit when you are ready. Thank you for your consideration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9604
added location field to ProviderForm
added location foreign key to CircuitTermination
added location field to circuittermination_edit.html template
updated circuits table to display Side A/B value via this logic: