Closes #6414: Enable assigning prefixes to various object types #17692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
requested changes
Oct 10, 2024
| initial['scope'] = instance.scope | ||
| kwargs['initial'] = initial | ||
|
|
||
| super().__init__(*args, **kwargs) |
There was a problem hiding this comment.
again seems like a good potential place for a mixin to reduce boilerplate as we are going to be using this same pattern in about 5 places.
jeremystretch
force-pushed
the
6414-prefix-scope-gfk
branch
from
c732a71 to
85c2490
Compare
|
Temporarily blocked by some prework for GFK bulk edit support in #17789 |
jeremystretch
added
status: blocked
jeremystretch
force-pushed
the
6414-prefix-scope-gfk
branch
from
0b6673e to
d10956e
Compare
|
There's an issue with generating filters for related models, because they're picking up the leading underscore of the ForeignKey fields. Trying to decide if we should ditch the underscores or adapt the dynamic logic to account for these (which will probably involve introspecting the model's filterset). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6414
scopeGenericForeignKey on PrefixsiteForeignKey field from Prefix