-
Notifications
You must be signed in to change notification settings - Fork 2.7k
18896 Replace STORAGE_BACKEND with STORAGES and support Script running from S3 #18680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Found a few things I think we can clean up.
@arthanson could you submit a retroactive FR for this work please? The scope of #18423 was just the configuration parameter change. The changes here have a far broader impact (such as introducing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arthanson!
This still needs a corresponding FR which captures the full extent of changes made in the PR. #18423 is not sufficient for this in its current form. |
Expanded the issue with more details. Please let me know if there are any details missing or how it should be expanded if needed. |
@arthanson please revert your edits to #18423 and open a new feature request to capture the intent of this PR, and re-target this PR to the new FR. I opened #18423 solely to propose a change to the configuration parameters in use. I'm not comfortable having it appear as though I requested this change; my involvement in this work has been limited to reviewing the proposed changes at a technical level. |
Created issue #18896 |
Fixes: #18896 (and #18423)
This Allows scripts to be run from S3 as well as config changes to allow for setting it. The changes are in two basic parts - the Script Form is changed to upload files using Django-storages (either FileSystem or S3) and the Script module loader is changed to pull from Django-storages.
Note: the Script convenience methods
load_yaml
andload_json
are not compatible when using S3 as they go direct to the local file system and are based on the path of the Script so wouldn't be backwards compatible. They are convenience functions so the script author could write them directly.RELEASE_NOTES should probably have a section about replacing STORAGE_BACKEND and STORAGE_CONFIG with STORAGES for those updating from a previous version.