-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Closes #17608: Adds L2VPN.status field #18791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@arthanson , since you won the review lottery: any guidance on what types of fields should be added to a model's |
|
There isn't a set rule - It's used for create and add another for defaulting fields when entering many items, so generally anything that isn't a unique constraint or you will probably change anyways (name, description, position). Status is generally included in cloned_fields, if not probably either a specific reason or an oversight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - should add a test to test_filtersets and maybe test_api as well as it is a required field so not just testing the default.
Also rearranges L2VPNStatusChoices so that the default value (active) is first.
Per conversation suggestion in PR. Thanks @arthanson!
a63b52d
to
7bd708b
Compare
Fixes: #17608
L2VPN.status
field withL2VPNStatusChoices
as choicesL2VPN.status
L2VPN.status
L2VPN.status
L2VPNIndex
to displaystatus
in resultsL2VPN.status
field