Fixes #17443: Adds ExportTemplate.file_name field #18911
Conversation
jnovinger
requested review from
a team and
bctiemann
and removed request for
a team
jeremystretch
requested review from
jeremystretch
and removed request for
bctiemann
There was a problem hiding this comment.
Thanks @jnovinger! Just had some very minor cleanup suggestions.
| @@ -155,6 +155,10 @@ class ExportTemplateBulkEditForm(BulkEditForm): | |||
| max_length=50, | |||
| required=False | |||
| ) | |||
| file_name = forms.CharField( | |||
There was a problem hiding this comment.
We should add file_name to nullable_fields below as well, to enable the "set null" option in the bulk edit form.
There was a problem hiding this comment.
Any guidance on when a field should or should not be included in nullable_fields?
There was a problem hiding this comment.
Ideally any optional, non-M2M field on the model should be nullable, I think. There are probably some exceptions to that rule but none come to mind offhand.
|
@jeremystretch , rather than adding another schema migration, I edited the existing migration to reflect the new max length for |
|
Ah, looks like there are some conflicting migrations from a recent merge to |
- Adds `file_name` to `ExportTemplateBulkEditForm.nullable_fields` - Shortens max length of `ExportTemplate.file_name` to 200 chars - Adds tests for `ExportTemplateFilterSet.file_extension`
jnovinger
force-pushed
the
17443-exporttemplate-filename-field
branch
from
b78824e to
76bf80a
Compare
Fixes: #17443
ExportTemplate.file_namefieldExportTemplate.render_to_response()to usefile_nameif populatedfilename_from_model, to standardize generating export filenames for models