Closes #18191: Remove duplicate SQL indexes #19074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
jnovinger
and removed request for
a team
|
I forgot; we wanted to look into adding a check for duplicate indexes as well. Let me dig into that. |
jnovinger
approved these changes
Apr 3, 2025
|
|
||
|
|
||
| @register(Tags.models) | ||
| def check_duplicate_indexes(app_configs, **kwargs): |
There was a problem hiding this comment.
😍 I honestly think it is worth checking if Django is interested in having this or something like this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18191
Note: I did also perform an audit for any additional redundant indexes, but did not uncover any that weren't already listed in #18191.