Skip to content

Fixes #18879 - Add prefix filtering by assigned VLAN Group #19182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pheus
Copy link
Contributor

@pheus pheus commented Apr 14, 2025

Fixes #18879 - Add prefix filtering by assigned VLAN Group

Overview

This PR enhances NetBox by enabling filtering of prefixes by the assigned VLAN Group. Users can now filter using both quick search (by VLAN Group slug) and FilterForm (by ID).

Changes Introduced

  • IPAM FilterSet: Added VLAN Group filters to support filtering by both ID and slug.
  • IPAM FilterForm: Introduced a vlan_group_id filter for direct filtering by VLAN Group.
  • Testing: Added tests to validate VLAN Group filtering.

Thank you for reviewing this PR!

pheus added 2 commits April 13, 2025 13:13
Introduces filters for VLAN groups using both ID and slug fields.
Introduces a `vlan_group_id` filter to IPAM forms for filtering based on
VLAN groups.
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one minor note this looks good to go. Thanks!

Introduces tests for VLAN group filtering in FilterSets. This ensures
correct validation and behavior when filtering by VLAN group.
@pheus pheus force-pushed the 18879-add-prefix-filtering-by-vlan-group branch from bbb52b4 to 1fb2d1c Compare April 14, 2025 20:36
@pheus pheus requested a review from jeremystretch April 14, 2025 20:50
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pheus!

@jeremystretch jeremystretch merged commit bb9b0b8 into netbox-community:main Apr 15, 2025
3 checks passed
@pheus pheus deleted the 18879-add-prefix-filtering-by-vlan-group branch April 15, 2025 15:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prefix filtering by assigned VLAN group
2 participants