Fixes #19529: Properly find scripts managed by ScriptFileSystemStorage #19568
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptFileSystemStorage was introduced in #18896 and stores a full path in Script.file_path. This fix handles looking for scripts by relative path as well as full path.
arthanson
requested changes
May 27, 2025
There was a problem hiding this comment.
As per discussion: "I found that both partial relative and full paths ended up being present in the Script.path field." this would be a bug that should get fixed there via data-migration I think - otherwise all further script processing will need to take into account that this can either be a full or relative path - they should be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19529
ScriptFileSystemStoragewas introduced in #18896 and stores a full path inScript.file_path. This fix handles looking for scripts by relative path as well as full path.