Skip to content

Node and Edge tables disappear #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdanish opened this issue Sep 9, 2020 · 3 comments
Closed

Node and Edge tables disappear #137

jdanish opened this issue Sep 9, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jdanish
Copy link
Collaborator

jdanish commented Sep 9, 2020

If you load a network and click on the node or edge table they appear as expected. Then, click on a node in the graph to select it. If you now click on the node or edge tab the tables are empty.

@jdanish jdanish added the bug Something isn't working label Sep 9, 2020
@benloh
Copy link
Collaborator

benloh commented Sep 9, 2020

Actually I think this is an error where reselecting a nodetable or edgetable does not update the data.

@benloh
Copy link
Collaborator

benloh commented Sep 9, 2020

Degrees seem to not update either...

@benloh
Copy link
Collaborator

benloh commented Sep 10, 2020

This was being caused by the bMarkedNode optimization skipping D3DATA updates. NodeTables and EdgeTables wouldn't re-render themselves if a node was selected.

The bMarkedNode optimization to skip table updates when a node is selected would also prevent the tables from rendering when switching tab panels.

If it's necessary to skip a render on selection, the check should be made on selection state.

Hopefully with the table optimizations this is no longer necessary.

Fixed with 0e4a15f
See also #136.

@benloh benloh closed this as completed Sep 10, 2020
@benloh benloh mentioned this issue Sep 17, 2020
benloh added a commit that referenced this issue Sep 5, 2024
Skip import of blank lines for nodes and edges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants