Skip to content

Delete node causes error #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdanish opened this issue Mar 30, 2022 · 4 comments
Closed

Delete node causes error #235

jdanish opened this issue Mar 30, 2022 · 4 comments
Assignees
@benloh

Comments

@jdanish
Copy link
Collaborator

jdanish commented Mar 30, 2022

To reproduce, open a network, select a node, click delete (happens with and without merging). There appears to be no change. Check the console and see the error below. Reload and change becomes visible. Note that other viewers don't see a change unless they reload as well.

Screen Shot 2022-03-30 at 5 57 51 PM
@benloh
Copy link
Collaborator

benloh commented Mar 31, 2022

Good catch! Fixing now.

@jdanish
Copy link
Collaborator Author

jdanish commented Mar 31, 2022 via email

@jdanish jdanish changed the title Debug causes error Delete node causes error Mar 31, 2022
@benloh
Copy link
Collaborator

benloh commented Mar 31, 2022 •
edited
Loading

@jdanish I believe 93bc853 should fix this. Just pushed. Should be fixed in #217

This was a side effect of our separating the core "raw" data from the "working" filtered data that was necessary to get import/export working. We ended up with a few straggling references to the deprecated data format. I think all the old references are now chased down as well.

@jdanish
Copy link
Collaborator Author

jdanish commented Apr 1, 2022

Looks good thanks!

@benloh benloh closed this as completed Apr 1, 2022
benloh pushed a commit that referenced this issue Sep 5, 2024
@dsriseah
Merge pull request #235 from netcreateorg/hotfix-for-234
01a6775 
hotfix-for-234: use POSIX dot command for Digital Ocean compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benloh benloh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benloh @jdanish