Problem Picking Target on New Edge

[jdanish]

Right now, if you click "add edge" the target field reads "pick one..." You cannot type into this field as you used to be able to. If you click on a node it will be selected. Then you can click "change target" and it works as previously (you see an autocomplete list). The autocomplete list should work when first loaded.

[benloh]

@jdanish Is this on the master branch or on 1.2.1cleanup?

[jdanish]

Hey @benloh, This is in 1.2.1cleanup I haven’t double-checked but it was fine previously on master so I assume it remains fine. Joshua

…

---- Joshua A. Danish Pronouns: he, him, his (https://www.mypronouns.org/ <https://www.mypronouns.org/>) [email protected] http://www.joshuadanish.com

On Jun 30, 2020, at 3:59 PM, benloh ***@***.***> wrote: @jdanish <https://github.com/jdanish> Is this on the master branch or on 1.2.1cleanup? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#94 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKGCKSWHIKKIK4X3YYGRKDRZI72VANCNFSM4OMSVKOA>.

[benloh]

@jdanish This should be fixed now with 57ce99c.

The problem was the optimization skipped constructing any components that weren't displayed when not in edit mode, so the call to enable the AutoComplete field was being made with a non-existing AutoComplete field.

In general, we probably need to completely rewrite the EdgeEditor to simplify it (or break out the components) now that we have a better grasp of what it needs to do.