-
Notifications
You must be signed in to change notification settings - Fork 3
Filter Feature #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Feature #169
Conversation
…ile that should not be in the repo.
…teredOut'. The parameters are redundant.
…gger the graph redraw.
…TA. D3DATA is the core data. We always only draw filtered data changes.
@jdanish @kalanicraig Here's a first pass at highlighting/filtering. There's still more to be done (see #167), but I believe this is functional enough to play with. Please give it a whirl and see how it feels. |
Sweet!! Looks really good. Three minor things I noticed at a glance that I am sure on your list but will note just in case:
Looking good! |
FYI, since my server is only for testing right now, I went ahead and updated it so we can play. Feel free to hop on as well: http://134.209.73.52/ The management password is the default. Looking good! |
Also just noticed if you type something in a filter and then hit enter it redirects to a page with an error. |
TO DO
|
…his is necessary for table updates to display current filtered data.
…ecrease font size, adjust column size.
…ated via radius, which in turn is already based on edge count.
@jdanish NodeTables and EdgeTables now show highlighted/filtered status. If highlighted, we use the same transparency value as defined in the filter. If removed (filtered) we show the item in red. |
Thanks! This appears to function as advertised and is very cool. It does have me wondering whether the filter panel would be easier to use if it was a popup that you could move around because it feels counter-intuitive to have to tab from it to others. I need to talk to Kalani more, but just floating that. Any thoughts? |
#172 should be fixed now. |
I find the problem with popups is you spend a lot of time fiddling with them and moving them out of the way all the time. That said, the current setup does eat up a LOT of space. Two ideas:
It shouldn't be too hard to convert it to a popup if we have to, though we'd probably want to figure out a new mechanism for opening it then, since it should no longer be a tab panel. |
For me, what makes it not work as a tab is that if you are looking at the tables, you need to pop back and forth. Ideally you could see the graph and table while changing the filters. Hence the popup idea. I honestly don't mind moving popups, but Kalani agrees with you. Anyhow, Kalani is going to check with Ann who has a lot more experience with all of the network visualization apps, and then we'll come back with a suggestion or decision to wait. Thanks! |
… React's 'hidden' because that prevents the graph size from being calculated. Addresses #171
Sounds like a good idea. If you have screenshots we can steal ideas. Things have been going pretty fast, so I think we can spend the time to design a nice UI for it. |
…e.id depending on whether d3 has transformed edge source/targets into node objects. Fixes #180.
Marking this done and ready to merge. |
This implements #167.
Branch:
dev-bl/filter
This introduces "Highlighting" and "Filtering" as separate but related features.
Whimsical graph data flow diagram
To Test
git fetch; git checkout dev-bl/filter
./nc.js --dataset=<yourdataset
-- Open a dataset that has a number of nodes and edges.The idea here is that the highlight/filter form acts the same across both conditions. This way you can easily toggle back and forth between fading (highlighting) and removing (filtering).
NOTE if you add a new node that is filtered out, it won't display.
As noted in #167, there are still a number of related features that are outstanding.