Edit Node Lock #50
Merged
Edit Node Lock #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" button is clicked.
…r ben to use as pattern
…if trying to edit a locked node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone begins editing a node, the node is now locked on the server and new users are prevented from editing the node. If they select a node and click "Edit Node" they will get a message about the node being locked.
To replicate:
The lock message can be changed via the template system.
A few known issues to be addressed later:
Currently this does not work on most nodes due to type consistency error that we are about to address in a new fix. Node ids in the database are often saved as strings when they need to be integers. As a result, the node matching algorithms are not finding matching nodes.
The selected node on the second browser is not currently updating.