hotfix-for-234: use POSIX dot command for Digital Ocean compatibility. #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see issue #234 for details
|
I had already confirmed this on my Digital Ocean instance that I use for URSYS testing, so I'll just accept it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way that
npm run devworks, as the system shell on Ubuntu is different than MacOs. Specifically, it replaces thesourcecommand with the "dot" command which is more universal.Previously, we had assumed that
/bin/shimplemented the same interface so if it worked on MacOs then it would work elsewhere. In actuality, the system shell is merely a "default shell" and can vary quite a lot.See issue #234 for details.
TESTING
npm run devYou should be greeted with something like this:
instead of