Skip to content

update-node-v18: nvmrc now v18.18.2 - #89

Merged
benloh merged 1 commit into
devfrom
dev-ds/update-node-v18
Nov 14, 2023
Merged

update-node-v18: nvmrc now v18.18.2#89
benloh merged 1 commit into
devfrom
dev-ds/update-node-v18

Conversation

@daveseah

@daveseah daveseah commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

This updates our official node target to v18.18.2, which is the latest version of the LTS v18 release. This is supported into April 2025. The version is stored in the .nvmrc file in the repo.

When updating node versions, it's generally a good idea to run the following commands again:

npm ci

as the package-lock.json file that contains dependencies has changed. There should be no issues since we were already on the v18 branch (previously, v18.16.0). We are making this change across all projects.

TO USE / TEST

  1. Pull the branch
  2. Make sure you are using the Visual Studio project file: netcreate-itest.code-workspace. This is how you should be making changes to netcreate, as the code workspace file contains important configuration settings that are only active.
  3. important rm -fr node_modules before running npm ci
  4. run netcreate normally, report any weird issues or crashes. Describe what you expected to happen, and include screenshots of what you saw instead (identify where to look so)

@benloh

benloh commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator

Works!

@benloh
benloh merged commit 098f302 into dev Nov 14, 2023
@benloh
benloh deleted the dev-ds/update-node-v18 branch November 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants