update-node-v18: nvmrc now v18.18.2 - #89
Merged
Merged
Conversation
Collaborator
|
Works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our official node target to v18.18.2, which is the latest version of the LTS v18 release. This is supported into April 2025. The version is stored in the
.nvmrcfile in the repo.When updating node versions, it's generally a good idea to run the following commands again:
as the
package-lock.jsonfile that contains dependencies has changed. There should be no issues since we were already on the v18 branch (previously, v18.16.0). We are making this change across all projects.TO USE / TEST
netcreate-itest.code-workspace. This is how you should be making changes to netcreate, as the code workspace file contains important configuration settings that are only active.rm -fr node_modulesbefore runningnpm ci